This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Heads up: cli subdirectory check in tonight


On Fri, Dec 01, 2000 at 12:48:02AM +0000, Fernando Nasser wrote:
> The take #3 of the CLI separation is the move of the CLI code to its
> own directory, into proper files.
> 
> I did this over the weekend and it has been working nicely since then.
> I have run the testusuite many times with no regression so it is time
> to check it in.
> 
> Again, I've tried to keep the changes to a minimum, basically only moving
> code that was scattered (I only tackled top.c and commands.c this time)
> so that the changes are properly documented.  
> 
> This means that the file cli/cli-cmds.c will change a lot in the future,
> but not now (I also want to post a RFC for that).
> 
> It also means that I left both the old and the new CLI command loop behind.
> That has to go in a different patch (it is time to get rid of the old code
> that has not been used for over an year anyway).
> 
> The new files will be (for now):
> 
> cli/cli-decode.c
> cli/cli-decode.h
> cli/cli-cmds.c
> cli/cli-cmds.h
> cli/cli-script.c
> cli/cli-script.h
> cli/cli-setshow.c
> cli/cli-setshow.h

It seems weird to have cli/cli-<xxx>.  I would think moving them to a new
subdirectory, you could rename them to cli/<xxx>.

-- 
Michael Meissner, Red Hat, Inc.
PMB 198, 174 Littleton Road #3, Westford, Massachusetts 01886, USA
Work:	  meissner@redhat.com		phone: +1 978-486-9304
Non-work: meissner@spectacle-pond.org	fax:   +1 978-692-4482

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]