Re: Heads up: cli subdirectory check in tonight

[Fernando Nasser <fnasser at cygnus dot com>]

Michael Meissner wrote:
> 
> On Fri, Dec 01, 2000 at 12:48:02AM +0000, Fernando Nasser wrote:
> > The take #3 of the CLI separation is the move of the CLI code to its
> > own directory, into proper files.
> >
> > I did this over the weekend and it has been working nicely since then.
> > I have run the testusuite many times with no regression so it is time
> > to check it in.
> >
> > Again, I've tried to keep the changes to a minimum, basically only moving
> > code that was scattered (I only tackled top.c and commands.c this time)
> > so that the changes are properly documented.
> >
> > This means that the file cli/cli-cmds.c will change a lot in the future,
> > but not now (I also want to post a RFC for that).
> >
> > It also means that I left both the old and the new CLI command loop behind.
> > That has to go in a different patch (it is time to get rid of the old code
> > that has not been used for over an year anyway).
> >
> > The new files will be (for now):
> >
> > cli/cli-decode.c
> > cli/cli-decode.h
> > cli/cli-cmds.c
> > cli/cli-cmds.h
> > cli/cli-script.c
> > cli/cli-script.h
> > cli/cli-setshow.c
> > cli/cli-setshow.h
> 
> It seems weird to have cli/cli-<xxx>.  I would think moving them to a new
> subdirectory, you could rename them to cli/<xxx>.
> 

Yes, I had the same doubts.  I believe I posted the question and I got only
only reply in favor of "cli-foo".

And we do currently have both mi and gdbtk subdirectories following the
"keep the prefix" rule.

I personally had no preferences but I admit this way prevents name clashes,
specially in these UI directories.  You see, these possible gdb dialects
like the CLI, the MI, some GUILE interface, our Tcl code etc may tend to
have things like "parser", "cmds", "cmdloop" etc.

This would not make sense in other contexts though.



-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9