This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: alpha-nat.c tweek


   Date: Wed, 6 Dec 2000 13:50:06 -0700
   From: Kevin Buettner <kevinb@cygnus.com>

   On Dec 3, 11:48am, Richard Henderson wrote:

   > 	* alpha-nat.c (supply_gregset, fill_gregset): Use gdb_gregset_t.
   > 	(supply_fpregset, fill_fpregset): Use gdb_fpregset_t.

   FWIW, I think these changes should be committed.  Similar changes have
   already been made to ppc-linux-nat.c.  Also, it should be noted that
   Richard's changes simply make the declarators for supply_gregset() and
   fill_gregset() match the declarations in gregset.h.

Indeed.  Because of some braindamage in Solaris and especially Linux,
gregset_t and fpregset_t are likely to be the wrong types.  If they
are, the (native) target should define GDB_GREGSET_T and
GDB_FPREGSET_T.  We already do that in config/nm-linux.h, so
everything should be fine.

   Hmm...  looking at the MAINTAINERS file, I see that there is no
   maintainer listed for the alpha target and that Richard is not in the
   "Write After Approval" list.  This means that some other maintainer
   with blanket write privileges will need to commit these changes.

Done.

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]