This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFC: Patch to arm-tdep.c -- Register flavors


Fernando,

I have a couple of minor nits:

Could you submit a unified diff instead of the context diff.  It would be easier
to read.  Personally I prefer diff -up.

I don't see the need for the code that is ifdef'ed out in _initialize_arm_tdep. 
You should resolve this before committing the patch.

Is the othernames command really necessary?  Perhaps we should take this
opportunity to remove it.  I won't miss it.  It's just another command to
document.

I think the default register names should be set by the port.  Most Linux users
don't use the APCS/ATPCS register names.  I don't find them intuitive at all
myself.

Scott

-- 
Scott Bambrough - Software Engineer
REBEL.COM    http://www.rebel.com
NetWinder    http://www.netwinder.org

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]