This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: Remaining GNU C isms.
- To: Robert Lipe <robertl at sco dot com>
- Subject: Re: Remaining GNU C isms.
- From: Fernando Nasser <fnasser at redhat dot com>
- Date: Sun, 20 Feb 2000 18:25:46 +0000
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Red Hat, Inc. - Toronto
- References: <20000219120800.R9448@rjlhome.sco.com>
Thanks Robert.
I have applied a patch from Philippe De Muyter that fixed that
occurrence and 3 others (on cli-out.c).
Maybe you could send one to language.c (I am not the maintainer but I
know it would be welcome).
Regards,
Fernando
Robert Lipe wrote:
>
> * cli-out.c (cli_field_string): align is enum, not int.
>
> Index: cli-out.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli-out.c,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 cli-out.c
> --- cli-out.c 2000/02/03 04:14:27 1.1.1.1
> +++ cli-out.c 2000/02/19 18:05:48
> @@ -194,7 +194,7 @@ void
> cli_field_string (struct ui_out *uiout,
> int fldno,
> int width,
> - int align,
> + enum ui_align align,
> char *fldname,
> const char *string)
> {
>
> Also, language.c has the non-C89 'long long' in a few places. Since
> they're marked with "FIXME" comments, I assume someone is already on top
> of this.
>
> ----- End forwarded message -----
--
Fernando Nasser
Red Hat, Inc. - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311
Toronto, Ontario M4P 2C9 Fax: 416-482-6299