Re: Heads up - Alpha ISO-C fixes

[Andrew Cagney <ac131313 at cygnus dot com>]

Andrew Cagney wrote:

> diff -upr gdb-19991116.orig/gdb/findvar.c gdb-19991116/gdb/findvar.c
> +++ gdb-19991116/gdb/findvar.c  Tue Nov 23 14:50:48 1999

The attatched cleans up part of findvar.c

	Andrew

PS: part of the problem is that include/ansidecl.h is defining ``PTR''
as ``char *''.  Ignoring that, these changes are due anyway.
Sat Mar  4 11:49:21 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	* defs.h (store_address, store_unsigned_integer, store_address):
 	Replace PTR with void* in delcaration.
	* findvar.c (extract_signed_integer, extract_unsigned_integer,
 	extract_long_unsigned_integer, extract_address,
 	store_signed_integer, store_unsigned_integer, store_address):
 	Convert definition to ISO-C.  Replace PTR with void*.

Index: gdb/defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.6
diff -p -r1.6 defs.h
*** defs.h	2000/03/04 00:40:40	1.6
--- defs.h	2000/03/04 00:56:04
*************** extern int extract_long_unsigned_integer
*** 1038,1048 ****
  
  extern CORE_ADDR extract_address (void *, int);
  
! extern void store_signed_integer (PTR, int, LONGEST);
  
! extern void store_unsigned_integer (PTR, int, ULONGEST);
  
! extern void store_address (PTR, int, LONGEST);
  
  /* Setup definitions for host and target floating point formats.  We need to
     consider the format for `float', `double', and `long double' for both target
--- 1038,1048 ----
  
  extern CORE_ADDR extract_address (void *, int);
  
! extern void store_signed_integer (void *, int, LONGEST);
  
! extern void store_unsigned_integer (void *, int, ULONGEST);
  
! extern void store_address (void *, int, LONGEST);
  
  /* Setup definitions for host and target floating point formats.  We need to
     consider the format for `float', `double', and `long double' for both target
Index: gdb/findvar.c
===================================================================
RCS file: /cvs/src/src/gdb/findvar.c,v
retrieving revision 1.3
diff -p -r1.3 findvar.c
*** findvar.c	2000/03/02 06:50:50	1.3
--- findvar.c	2000/03/04 00:56:07
*************** static int read_relative_register_raw_by
*** 57,66 ****
  you lose
  #endif
  
!   LONGEST
! extract_signed_integer (addr, len)
!      PTR addr;
!      int len;
  {
    LONGEST retval;
    unsigned char *p;
--- 57,64 ----
  you lose
  #endif
  
! LONGEST
! extract_signed_integer (void *addr, int len)
  {
    LONGEST retval;
    unsigned char *p;
*************** That operation is not available on integ
*** 94,102 ****
  }
  
  ULONGEST
! extract_unsigned_integer (addr, len)
!      PTR addr;
!      int len;
  {
    ULONGEST retval;
    unsigned char *p;
--- 92,98 ----
  }
  
  ULONGEST
! extract_unsigned_integer (void *addr, int len)
  {
    ULONGEST retval;
    unsigned char *p;
*************** That operation is not available on integ
*** 130,139 ****
     function returns 1 and sets *PVAL.  Otherwise it returns 0.  */
  
  int
! extract_long_unsigned_integer (addr, orig_len, pval)
!      PTR addr;
!      int orig_len;
!      LONGEST *pval;
  {
    char *p, *first_addr;
    int len;
--- 126,132 ----
     function returns 1 and sets *PVAL.  Otherwise it returns 0.  */
  
  int
! extract_long_unsigned_integer (void *addr, int orig_len, LONGEST *pval)
  {
    char *p, *first_addr;
    int len;
*************** extract_long_unsigned_integer (addr, ori
*** 177,185 ****
  }
  
  CORE_ADDR
! extract_address (addr, len)
!      PTR addr;
!      int len;
  {
    /* Assume a CORE_ADDR can fit in a LONGEST (for now).  Not sure
       whether we want this to be true eventually.  */
--- 170,176 ----
  }
  
  CORE_ADDR
! extract_address (void *addr, int len)
  {
    /* Assume a CORE_ADDR can fit in a LONGEST (for now).  Not sure
       whether we want this to be true eventually.  */
*************** extract_address (addr, len)
*** 187,196 ****
  }
  
  void
! store_signed_integer (addr, len, val)
!      PTR addr;
!      int len;
!      LONGEST val;
  {
    unsigned char *p;
    unsigned char *startaddr = (unsigned char *) addr;
--- 178,184 ----
  }
  
  void
! store_signed_integer (void *addr, int len, LONGEST val)
  {
    unsigned char *p;
    unsigned char *startaddr = (unsigned char *) addr;
*************** store_signed_integer (addr, len, val)
*** 217,226 ****
  }
  
  void
! store_unsigned_integer (addr, len, val)
!      PTR addr;
!      int len;
!      ULONGEST val;
  {
    unsigned char *p;
    unsigned char *startaddr = (unsigned char *) addr;
--- 205,211 ----
  }
  
  void
! store_unsigned_integer (void *addr, int len, ULONGEST val)
  {
    unsigned char *p;
    unsigned char *startaddr = (unsigned char *) addr;
*************** store_unsigned_integer (addr, len, val)
*** 250,259 ****
     gdb-local memory pointed to by "addr"
     for "len" bytes. */
  void
! store_address (addr, len, val)
!      PTR addr;
!      int len;
!      LONGEST val;
  {
    store_unsigned_integer (addr, len, val);
  }
--- 235,241 ----
     gdb-local memory pointed to by "addr"
     for "len" bytes. */
  void
! store_address (void *addr, int len, LONGEST val)
  {
    store_unsigned_integer (addr, len, val);
  }