This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch to gdb.texinfo



> Please apply this patch to gdb.texinfo (revision 1.1.1.14).
> This fixes several typos and markup inconsistences.

Thanks!  A few comments:

>  @kindex quit @r{[}@var{expression}@r{]}
>  @kindex q
>  @item quit
> +@item quit @r{[}@var{expression}@r{]}

This should be @itemx, not @item (since this is in a @table).  Or did
you intend to remove "@item quit"?

> -String constants are a sequence of character constants surrounded
> -by double quotes (@code{"}).
> +String constants are a sequence of character constants (without
> +single quotes) surrounded by double quotes (@code{"}).

I think "without single quotes" is ambiguous.  I suggest "not
including single quote characters @samp{'}" instead.  I also suggest
to use @samp, not @code here.  A bare @code is IMHO not suitable for
character constants, as it lacks the delimiting quotes.

> -For complicated cases, you can specify an arbitrary number of @r{-T}@var{section} @var{address}
> +For complicated cases, you can specify an arbitrary number of @samp{@r{-T}@var{section} @var{address}}

I don't see the rationale for this change.  Could you please explain?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]