This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[PATCH]: add set/show debug, move gdb debugging flags into it


Attached is a patch to add "set debug" and "show debug", and move the gdb
debugging stuff (targetdebug,expressiondebug,etc) into those lists.

I renamed targetdebug,expressiondebug,etc (all the debug settings i
moved), to remove the "debug" from their name, so you do "set debug target
1" rather than "set debug targetdebug 1".

The new command lists are named setdebuglist/showdebuglist, and are in
command.c.
I put set_debug and show_debug into command.c, for lack of a better place.
The point of all this is to make it much easier to see what debugging
flags you can set for GDB, and what they were set to. It also declutters
the set list.
I also enabled monitordebug, since it said int he comment it was waiting
for "set debug".

I have no idea who needs to approve this, since it touches a bunch of
stuff, but is only related to one domain so to speak.

I'm working on a changelog entry,  i wanted to get comments first.

Example of what you get with the patch installed:
(gdb) help set debug
Generic command for setting gdb debugging flags
List of set debug subcommands:
set debug arch -- Set architecture debugging
set debug event -- Set event debugging
set debug expression -- Set expression debugging
set debug remote -- Set debugging of remote protocol
set debug serial -- Set serial debugging
set debug target -- Set target debugging
set debug varobj -- Set varobj debugging
Type "help set debug" followed by set debug subcommand name for full
documentation.
Command name abbreviations are allowed if unambiguous.
(gdb)

(gdb) help show debug
Generic command for showing gdb debugging flags
List of show debug subcommands:
show debug arch -- Show architecture debugging
show debug event -- Show event debugging
show debug expression -- Show expression debugging
show debug remote -- Show debugging of remote protocol
show debug serial -- Show serial debugging
show debug target -- Show target debugging
show debug varobj -- Show varobj debugging
Type "help show debug" followed by show debug subcommand name for full
documenta
tion.
Command name abbreviations are allowed if unambiguous.
(gdb)
(gdb) show debug
arch:  Architecture debugging is 0.
event:  Event debugging is 0.
expression:  Expression debugging is 0.
remote:  Debugging of remote protocol is 0.
serial:  Serial debugging is 0.
target:  Target debugging is 0.
varobj:  Varobj debugging is 0.
(gdb) set debug
"set debug" must be followed by the name of a print subcommand.
List of set debug subcommands:
set debug arch -- Set architecture debugging
set debug event -- Set event debugging
set debug expression -- Set expression debugging
set debug remote -- Set debugging of remote protocol
set debug serial -- Set serial debugging
set debug target -- Set target debugging
set debug varobj -- Set varobj debugging
Type "help set debug" followed by set debug subcommand name for full
documentati
on.
Command name abbreviations are allowed if unambiguous.
(gdb)

Index: gdb-events.c
===================================================================
RCS file: /cvs/src/src/gdb/gdb-events.c,v
retrieving revision 1.1.1.2
diff -r1.1.1.2 gdb-events.c
222c222
<   add_show_from_set (add_set_cmd ("eventdebug",
---
>   add_show_from_set (add_set_cmd ("event",
227,228c227,228
< When non-zero, event/notify debugging is enabled.", &setlist),
<                      &showlist);
---
> When non-zero, event/notify debugging is enabled.", &setdebuglist),
>                      &showdebuglist);
Index: gdbarch.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.c,v
retrieving revision 1.3
diff -r1.3 gdbarch.c
3278c3278
<   add_show_from_set (add_set_cmd ("archdebug",
---
>   add_show_from_set (add_set_cmd ("arch",
3283,3284c3283,3284
< When non-zero, architecture debugging is enabled.", &setlist),
< 		     &showlist);
---
> When non-zero, architecture debugging is enabled.", &setdebuglist),
> 		     &showdebuglist);
Index: gdbcmd.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbcmd.h,v
retrieving revision 1.1.1.5
diff -r1.1.1.5 gdbcmd.h
98a99,102
> extern struct cmd_list_element *setdebuglist;
> 
> extern struct cmd_list_element *showdebuglist;
> 
Index: monitor.c
===================================================================
RCS file: /cvs/src/src/gdb/monitor.c,v
retrieving revision 1.2
diff -r1.2 monitor.c
2413,2415d2412
< #if 0
<   /* FIXME: cagney/1999-10-07: Wait until there is a generic ``set
<      debug ...'' rather than another ``set ...debug'' command. */
2417c2414
<     (add_set_cmd ("monitordebug", no_class, var_zinteger,
---
>     (add_set_cmd ("monitor", no_class, var_zinteger,
2421,2423c2418,2419
< is displayed.", &setlist),
<      &showlist);
< #endif
---
> is displayed.", &setdebuglist),
>      &showdebuglist);
Index: parse.c
===================================================================
RCS file: /cvs/src/src/gdb/parse.c,v
retrieving revision 1.1.1.11
diff -r1.1.1.11 parse.c
1403c1403
< 	    add_set_cmd ("expressiondebug", class_maintenance, var_zinteger,
---
> 	    add_set_cmd ("expression", class_maintenance, var_zinteger,
1407,1408c1407,1408
< 			 &setlist),
< 		      &showlist);
---
> 			 &setdebuglist),
> 		      &showdebuglist);
Index: serial.c
===================================================================
RCS file: /cvs/src/src/gdb/serial.c,v
retrieving revision 1.1.1.10
diff -r1.1.1.10 serial.c
675c675
<   add_show_from_set (add_set_cmd ("serialdebug",
---
>   add_show_from_set (add_set_cmd ("serial",
680,681c680,681
< When non-zero, serial port debugging is enabled.", &setlist),
< 		     &showlist);
---
> When non-zero, serial port debugging is enabled.", &setdebuglist),
> 		     &showdebuglist);
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.3
diff -r1.3 target.c
3052c3052
< 		add_set_cmd ("targetdebug", class_maintenance, var_zinteger,
---
> 		add_set_cmd ("target", class_maintenance, var_zinteger,
3055,3056c3055,3056
< When non-zero, target debugging is enabled.", &setlist),
< 		      &showlist);
---
> When non-zero, target debugging is enabled.", &setdebuglist),
> 		      &showdebuglist);
Index: top.c
===================================================================
RCS file: /cvs/src/src/gdb/top.c,v
retrieving revision 1.4
diff -r1.4 top.c
146a147,150
> static void show_debug PARAMS ((char *, int));
> 
> static void set_debug PARAMS ((char *, int));
> 
257a262,265
> struct cmd_list_element *setdebuglist;
> 
> struct cmd_list_element *showdebuglist;
> 
3984c3992,4009
< 
---
> 
> static void
> set_debug (arg, from_tty)
> 	char *arg;
> 	int from_tty;
> {
> 	printf_unfiltered (
> 			"\"set debug\" must be followed by the name of a print subcommand.\n");
> 	help_list (setdebuglist, "set debug ", -1, gdb_stdout);
> }
> 
> static void
> show_debug (args, from_tty)
> 	char *args;
> 	int from_tty;
> {
> 	          cmd_show_list (showdebuglist, from_tty, "");
> }
4312c4337
<   add_set_cmd ("remotedebug", no_class, var_zinteger, (char *) &remote_debug,
---
>   add_set_cmd ("remote", no_class, var_zinteger, (char *) &remote_debug,
4315,4316c4340,4341
< is displayed.", &setlist),
< 		      &showlist);
---
> is displayed.", &setdebuglist),
> 		      &showdebuglist);
4355a4381,4383
> 	add_prefix_cmd("debug",no_class,set_debug, "Generic command for setting gdb debugging flags", &setdebuglist, "set debug ", 0, &setlist);
> 
> 	add_prefix_cmd("debug",no_class,show_debug,"Generic command for showing gdb debugging flags", &showdebuglist, "show debug ", 0, &showlist);
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 varobj.c
2416c2416
< 		add_set_cmd ("debugvarobj", class_maintenance, var_zinteger,
---
> 		add_set_cmd ("varobj", class_maintenance, var_zinteger,
2419,2420c2419,2420
< When non-zero, varobj debugging is enabled.", &setlist),
< 		      &showlist);
---
> When non-zero, varobj debugging is enabled.", &setdebuglist),
> 		      &showdebuglist);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]