This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [MAINT/PATCH] ChangeLog et.al.: Revert whitespace changes
- To: ac131313 at cygnus dot com
- Subject: Re: [MAINT/PATCH] ChangeLog et.al.: Revert whitespace changes
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Fri, 31 Mar 2000 18:32:46 -0500 (EST)
- CC: gdb-patches at sourceware dot cygnus dot com
- References: <38DEF05E.9D2E79AC@cygnus.com>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> I've just committed the attatched. It reverts a string of arbitrary
> whitespace changes made to various files including ChangeLogs.
>
> For ChangeLogs, they should be prepend-only.
Sorry, I don't understand some of these changes, like this one:
> *************** Fri Mar 17 11:06:59 2000 Philippe De Mu
> *** 429,435 ****
> * config/i386/tm-linux.h (I386_LINUX_SIGTRAMP): No need to define
> this any more, since we're not enabling OS-specific code in a
> OS-independent file.
> !
> 2000-03-16 Eli Zaretskii <eliz@is.elta.co.il>
>
> * Makefile.in (go32-nat.o): Add prerequisites.
> --- 433,439 ----
> * config/i386/tm-linux.h (I386_LINUX_SIGTRAMP): No need to define
> this any more, since we're not enabling OS-specific code in a
> OS-independent file.
> !
> 2000-03-16 Eli Zaretskii <eliz@is.elta.co.il>
>
> * Makefile.in (go32-nat.o): Add prerequisites.
The only change here is that in the new version, there's extra
whitespace in an otherwise empty line. It's quite possible that some
editor (such as Emacs) removed the whitespace when somebody pressed
M-q to reformat the paragraph.
While I understand the importance of avoiding gratuitous whitespace
changes, introducing extra blanks in ChangeLogs seems like the wrong
way to do it, especially since they are subject to disappearence
without notice. Those blanks shouldn't have been there in the first
place.