This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] fix for infinite recursion in lookup_symbol
- To: Daniel Berlin <dberlin at redhat dot com>
- Subject: Re: [patch] fix for infinite recursion in lookup_symbol
- From: Jim Ingham <jingham at apple dot com>
- Date: Fri, 12 Jan 2001 14:03:44 -0800
- Cc: gdb-patches at sources dot redhat dot com
Daniel,
Well, while you are waiting, it might be nice to check in fixes for some
of these, since they are pretty simple fixes, and the bugs are pretty
annoying (in this case it causes gdb to crash, and people tend to REALLY
hate it when their debugger crashes). It wasted a couple of days of my
time chasing it down, and apparently a couple of days of Fernando's time
as well.
Jim
On Friday, January 12, 2001, at 12:10 PM, Daniel Berlin wrote:
>
>
> On Fri, 12 Jan 2001, Jim Ingham wrote:
>
>> Hi, all,
>>
>> The following patch fixes an infinite recursion in the variable lookup
>> code for C++ objects that are specified in mangled form. The old code
>> would take the mangled name into lookup_symbol, unmangle it, and then
>> in
>> this bit pass the mangled name BACK to lookup_symbol, which would
>> unmangle it and come right back here... Not a good thing. The bug
>> crept in when lookup_symbol was broken up into lookup_symbol and
>> lookup_symbol_aux, the correction is clearly what was meant.
>
> This was already known, and we are still waiting for Jim Blandy to
> make a
> decision whether we should revert the binary searching symbol lookup for
> C++ stuff or not.
> If we decide to stay with the non-linear symbol lookup, i'll fix the
> bugs,
> as i already have patches for most of them (there aren't many).
>
> --Dan
>