This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Fix to build arc-tdep.c with new ARC machine numbers
- To: ac131313 at cygnus dot com
- Subject: Re: RFA: Fix to build arc-tdep.c with new ARC machine numbers
- From: Nick Clifton <nickc at redhat dot com>
- Date: Thu, 18 Jan 2001 20:07:43 -0800
- CC: peter dot targett at arccores dot com, gdb-patches at sources dot redhat dot com
Hi Andrew,
I am forwarding your message to Peter Taggert, who contributed the
ARC rewrite. I will check in the current GDB patch, since it at
least allows the toolchain to build for now.
Cheers
Nick
------- Start of forwarded message -------
From: Andrew Cagney <ac131313@cygnus.com>
To: Nick Clifton <nickc@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Fix to build arc-tdep.c with new ARC machine numbers
Nick Clifton wrote:
>
> Hi Guys,
>
> The ARC port in binutils was recently changes by a submission from
> Peter Taggert at arccores.com. This change introduced some new
> machine numbers for the ARC and also changed how the disassembler is
> invoked. The patch below makes adjustments to arc-tdep.c for both
> of these changes.
>
> OK to apply ?
Approved (but with reservations).
If the ARC target is going to have a long term future then it needs to
move away from this arc_cpu_type[] table and onto multi-arch. If there
is any intention to extend the ARC target support beyond this simple
patch then, again, it will need to first be multi-arched.
Andrew
> Cheers
> Nick
>
> 2001-01-11 Nick Clifton <nickc@redhat.com>
>
> * arc-tdep.c (arc_cpu_type_table): Add new arc core numbers.
> (arc_print_insn): No bfd available, so pass NULL to
> arc_get_disassembler.
>
> Index: gdb/arc-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/arc-tdep.c,v
> retrieving revision 1.3
> diff -p -r1.3 arc-tdep.c
> *** arc-tdep.c 2000/07/30 01:48:24 1.3
> --- arc-tdep.c 2001/01/11 21:27:27
> *************** struct
> *** 44,56 ****
> }
> arc_cpu_type_table[] =
> {
> ! {
> ! "base", bfd_mach_arc_base
> ! }
> ! ,
> ! {
> ! NULL, 0
> ! }
> };
>
> /* Used by simulator. */
> --- 44,54 ----
> }
> arc_cpu_type_table[] =
> {
> ! { "arc5", bfd_mach_arc_5 },
> ! { "arc6", bfd_mach_arc_6 },
> ! { "arc7", bfd_mach_arc_7 },
> ! { "arc8", bfd_mach_arc_8 },
> ! { NULL, 0 }
> };
>
> /* Used by simulator. */
> *************** arc_print_insn (bfd_vma vma, disassemble
> *** 618,625 ****
> {
> current_mach = arc_bfd_mach_type;
> current_endian = TARGET_BYTE_ORDER;
> ! current_disasm = arc_get_disassembler (current_mach,
> ! current_endian == BIG_ENDIAN);
> }
>
> return (*current_disasm) (vma, info);
> --- 616,622 ----
> {
> current_mach = arc_bfd_mach_type;
> current_endian = TARGET_BYTE_ORDER;
> ! current_disasm = arc_get_disassembler (NULL);
> }
>
> return (*current_disasm) (vma, info);
------- End of forwarded message -------