This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH]: memory region attribute nits
- To: gdb-patches at sourceware dot cygnus dot com
- Subject: [PATCH]: memory region attribute nits
- From: jtc at redback dot com (J.T. Conklin)
- Date: 23 Jan 2001 16:30:10 -0800
- Reply-To: jtc at redback dot com
It was brought to my attention that today's checkin of memory region
attribute support broke builds on some targets because their memory
transfer functions had not been updated. Many appologies for this
oversight. While I try to build GDB on many architectures, most are
embedded targets.
This change has now been committed.
--jtc
2001-01-23 J.T. Conklin <jtc@redback.com>
* lin-lwp.c (lin_lwp_xfer_memory): Add attrib argument.
* thread-db.c (thread_db_xfer_memory): Likewise.
Index: thread-db.c
===================================================================
RCS file: /cvs/src/src/gdb/thread-db.c,v
retrieving revision 1.3
diff -c -r1.3 thread-db.c
*** thread-db.c 2000/12/27 21:37:57 1.3
--- thread-db.c 2001/01/24 00:25:54
***************
*** 753,758 ****
--- 753,759 ----
static int
thread_db_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write,
+ struct mem_attrib *attrib,
struct target_ops *target)
{
struct cleanup *old_chain = save_inferior_pid ();
***************
*** 768,774 ****
inferior_pid = lwp_from_thread (inferior_pid);
}
! xfer = target_beneath->to_xfer_memory (memaddr, myaddr, len, write, target);
do_cleanups (old_chain);
return xfer;
--- 769,775 ----
inferior_pid = lwp_from_thread (inferior_pid);
}
! xfer = target_beneath->to_xfer_memory (memaddr, myaddr, len, write, attrib, target);
do_cleanups (old_chain);
return xfer;
Index: lin-lwp.c
===================================================================
RCS file: /cvs/src/src/gdb/lin-lwp.c,v
retrieving revision 1.4
diff -c -r1.4 lin-lwp.c
*** lin-lwp.c 2000/12/15 01:01:48 1.4
--- lin-lwp.c 2001/01/24 00:25:56
***************
*** 935,940 ****
--- 935,941 ----
static int
lin_lwp_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write,
+ struct mem_attrib *attrib,
struct target_ops *target)
{
struct cleanup *old_chain = save_inferior_pid ();
***************
*** 943,949 ****
if (is_lwp (inferior_pid))
inferior_pid = GET_LWP (inferior_pid);
! xfer = child_xfer_memory (memaddr, myaddr, len, write, target);
do_cleanups (old_chain);
return xfer;
--- 944,950 ----
if (is_lwp (inferior_pid))
inferior_pid = GET_LWP (inferior_pid);
! xfer = child_xfer_memory (memaddr, myaddr, len, write, attrib, target);
do_cleanups (old_chain);
return xfer;
--
J.T. Conklin
RedBack Networks