[RFA] Change free to xfree

[J Moore <jmoore at cygnus dot com>]

Changed free () to xfree()

From the ARI list (http://sources.redhat.com/gdb/ari) these
diffs correct the ones that actually have this problem. The 
modifications have been tested using Red-Hat Linux 7.0 using 
a linux-2.4.0 kernel.

List of files that don't need correction (should be removed
from the ARI list in this category):

	config/pa/xm-hppah.h: forward reference of free() only.
	defs.h: forward reference of free() only.
	utils.c: xfree() gets defined here and calls free() correctly.

2001-01-24  John R. Moore  <jmoore@cygnus.com>

        * cli/cli-cmds.c (apropos_command) Changed free to xfree where appropriate.
        * gdbarch.c (gdbarch_free) Likewise.
        * gdbserver/low-sim.c (mygeneric_load) Likewise.
        * remote-utils.h (sr_set_device) Likewise.
        * symtab.h (obstack_chunk_free, SYMBOL_INIT_DEMANGLED_NAME) Likewise.
        * value.h  (value_free) Likewise.


The following diff patches are requested for approval:

Index: cli/cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.2
diff -p -u -w -r1.2 cli-cmds.c
--- cli-cmds.c	2000/12/15 01:01:51	1.2
+++ cli-cmds.c	2001/01/24 17:35:30
@@ -557,7 +557,7 @@ apropos_command (char *searchstr, int fr
       regerror(regcomp(&pattern,searchstr,REG_ICASE),NULL,errorbuffer,512);
       error("Error in regular expression:%s",errorbuffer);
     }
-  free(pattern_fastmap);
+  xfree(pattern_fastmap);
 }
 
 static void



Index: gdbarch.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.c,v
retrieving revision 1.51
diff -p -u -w -r1.51 gdbarch.c
--- gdbarch.c	2001/01/22 23:32:49	1.51
+++ gdbarch.c	2001/01/24 17:35:42
@@ -467,7 +467,7 @@ void
 gdbarch_free (struct gdbarch *arch)
 {
   /* At the moment, this is trivial.  */
-  free (arch);
+  xfree (arch);
 }
 
 
Index: gdbserver/low-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/low-sim.c,v
retrieving revision 1.3
diff -p -u -w -r1.3 low-sim.c
--- low-sim.c	2001/01/23 19:45:12	1.3
+++ low-sim.c	2001/01/24 17:35:47
@@ -69,7 +69,7 @@ mygeneric_load (bfd *loadfile_bfd)
 	      bfd_get_section_contents (loadfile_bfd, s, buffer, 0, size);
 
 	      write_inferior_memory (lma, buffer, size);
-	      free (buffer);
+	      xfree (buffer);
 	    }
 	}
     }



Index: remote-utils.h
===================================================================
RCS file: /cvs/src/src/gdb/remote-utils.h,v
retrieving revision 1.5
diff -p -u -w -r1.5 remote-utils.h
--- remote-utils.h	2000/11/03 22:00:56	1.5
+++ remote-utils.h	2001/01/24 17:35:50
@@ -53,7 +53,7 @@ extern struct _sr_settings sr_settings;
 #define sr_get_device()			(sr_settings.device)
 #define sr_set_device(newval) \
 { \
-    if (sr_settings.device) free(sr_settings.device); \
+    if (sr_settings.device) xfree(sr_settings.device); \
     sr_settings.device = (newval); \
 }



 
Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.16
diff -p -u -w -r1.16 symtab.h
--- symtab.h	2000/11/10 23:02:56	1.16
+++ symtab.h	2001/01/24 17:35:55
@@ -26,7 +26,7 @@
 
 #include "obstack.h"
 #define obstack_chunk_alloc xmalloc
-#define obstack_chunk_free free
+#define obstack_chunk_free xfree
 #include "bcache.h"
 
 /* Don't do this; it means that if some .o's are compiled with GNU C
@@ -182,7 +182,7 @@ extern CORE_ADDR symbol_overlayed_addres
 	    SYMBOL_LANGUAGE (symbol) = language_cplus;			\
 	    SYMBOL_CPLUS_DEMANGLED_NAME (symbol) = 			\
 	      obsavestring (demangled, strlen (demangled), (obstack));	\
-	    free (demangled);						\
+	    xfree (demangled);						\
 	  }								\
 	else								\
 	  {								\
@@ -199,7 +199,7 @@ extern CORE_ADDR symbol_overlayed_addres
 	    SYMBOL_LANGUAGE (symbol) = language_java;			\
 	    SYMBOL_CPLUS_DEMANGLED_NAME (symbol) = 			\
 	      obsavestring (demangled, strlen (demangled), (obstack));	\
-	    free (demangled);						\
+	    xfree (demangled);						\
 	  }								\
 	else								\
 	  {								\
@@ -217,7 +217,7 @@ extern CORE_ADDR symbol_overlayed_addres
 	    SYMBOL_LANGUAGE (symbol) = language_chill;			\
 	    SYMBOL_CHILL_DEMANGLED_NAME (symbol) = 			\
 	      obsavestring (demangled, strlen (demangled), (obstack));	\
-	    free (demangled);						\
+	    xfree (demangled);						\
 	  }								\
 	else								\
 	  {								\



Index: value.h
===================================================================
RCS file: /cvs/src/src/gdb/value.h,v
retrieving revision 1.13
diff -p -u -w -r1.13 value.h
--- value.h	2001/01/09 00:12:48	1.13
+++ value.h	2001/01/24 17:36:06
@@ -456,7 +456,7 @@ extern int unop_user_defined_p (enum exp
 
 extern int destructor_name_p (const char *name, const struct type *type);
 
-#define value_free(val) free ((PTR)val)
+#define value_free(val) xfree ((PTR)val)
 
 extern void free_all_values (void);