This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] More completion improvements
- To: Eli Zaretskii <eliz at is dot elta dot co dot il>, gdb-patches at sources dot redhat dot com
- Subject: Re: [RFA] More completion improvements
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Sun, 18 Feb 2001 09:40:30 -0700
- References: <Pine.SUN.3.91.1010218092227.4804N-100000@is>
On Feb 18, 9:31am, Eli Zaretskii wrote:
> * solib.c (_initialize_solib): Ditto for `solib-search-path' and
> `solib-absolute-prefix'.
Eli,
Your solib.c changes are approved.
I have a minor style criticism. I would prefer to see function calls
with an embedded assignment expression written as a separate assignment
statement followed by the function call. E.g, instead of writing...
add_show_from_set
(c = add_set_cmd ("solib-absolute-prefix", class_support, var_filename,
(char *) &solib_absolute_prefix,
"Set prefix for loading absolute shared library symbol files.\n\
For other (relative) files, you can add values using `set solib-search-path'.",
&setlist),
&showlist);
...write this instead:
c = add_set_cmd ("solib-absolute-prefix", class_support, var_filename,
(char *) &solib_absolute_prefix,
"Set prefix for loading absolute shared library symbol files.\n\
For other (relative) files, you can add values using `set solib-search-path'.",
&setlist);
add_show_from_set (c, &showlist);
The GNU coding standards do not explicitly address this case, but they
do address a similar case regarding if-conditions. See:
http://www.gnu.org/prep/standards_24.html#SEC24
Kevin