This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Extend demangler to recognize destructors/constructors
- To: Jim Blandy <jimb at zwingli dot cygnus dot com>
- Subject: Re: [RFA] Extend demangler to recognize destructors/constructors
- From: Gabriel Dos Reis <gdr at codesourcery dot com>
- Date: 15 Mar 2001 10:15:11 +0100
- Cc: gcc-patches at gcc dot gnu dot org, Daniel Berlin <dberlin at cygnus dot com>, Michael Elizabeth Chastain <chastain at cygnus dot com>, gdb-patches at sources dot redhat dot com
- Organization: CodeSourcery, LLC
- References: <200103150901.EAA25623@zwingli.cygnus.com>
Stylistic notes.
Jim Blandy <jimb@zwingli.cygnus.com> writes:
[...]
| +
| + /* Set to non-zero iff this name is a constructor. The actual value
| + is '1', '2', or '3', indicating a complete object, base object,
| + or complete object allocating constructor. */
| + int is_constructor;
| +
| + /* Set to non-zero iff this name is a destructor. The actual value
| + is '0', '1', or '2', indicating a deleting, complete object, or
| + base object destructor. */
| + int is_destructor;
May I suggest use of enums to make it much more readable? I realize
that makes
dm->is_destructor = peek_char (dm);
less straigthforward but will make use of
int
is_gnu_v3_mangled_constructor (const char *name)
and
int
is_gnu_v3_mangled_destructor (const char *name)
self explanatory.
-- Gaby
CodeSourcery, LLC http://www.codesourcery.com