This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Revised C++ ABI abstraction patches
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: [RFA] Revised C++ ABI abstraction patches
- From: Daniel Berlin <dberlin at redhat dot com>
- Date: 15 Mar 2001 21:58:34 -0500
- Cc: Jim Blandy <jimb at cygnus dot com>, gdb-patches at sources dot redhat dot com
- References: <200103150951.EAA25684@zwingli.cygnus.com><3AB148D9.CA2A668B@cygnus.com>
Andrew Cagney <ac131313@cygnus.com> writes:
> Jim,
>
> When Dan originally submitted his original patch it was large.
> Fortunatly it was only (mostly) the mechanical change of separating out
> the C++ stuff (it was also approved so I don't know why it wasn't
> committed).
It wasn't committed because it needed a little work.
By the time i finished the work, it had grown. Feature creep.
:(
> Now, however, the patch has managed to accumulate much much
> more (sigh). This really should be broken down into the mechanical
> change of creating a new file and the modifications that fix real
> bugs.
Yup.
Should I break it into the addition of the new files, and the others
changes?
Unfortunately, they'll be dependent on each other, but i can't think
of how to break it up so it isn't.
>
> enjoy,
> Andrew