This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[patch] Final fixes for -Wuninitialized -Werror
- To: GDB Patches <gdb-patches at sourceware dot cygnus dot com>
- Subject: [patch] Final fixes for -Wuninitialized -Werror
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Wed, 28 Mar 2001 16:41:04 -0500
FYI,
The attatched patch flushes out the remaining -Wuninitialized warnings,
adding it to the default set of compiler flags.
Andrew
2001-03-28 Andrew Cagney <ac131313@redhat.com>
* configure.in (build_warnings): Add -Wuninitialized.
* configure: Regenerate.
* v850-tdep.c (v850_scan_prologue): Initialize ``insn2''.
* sparc-tdep.c (sparc64_push_arguments): Add default case to
switch.
* sh-tdep.c (sh_do_fp_register): Replace ``?:'' printf format
expression with if statement.
* mn10200-tdep.c (mn10200_analyze_prologue): Initialize
``stack_size''.
* mips-tdep.c (show_mipsfpu_command): Add default case to switch.
(mips_dump_tdep): Fix setting of ef_mips_arch.
* mcore-tdep.c (mcore_analyze_prologue): Initialize ``fp_regnum''.
* dsrec.c (make_srec): Always initialize ``binbuf''.
* monitor.c (monitor_read_memory_single): Do not pass an
uninitialized buffer to monitor_error. Make ``i'' more local.
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.61
diff -p -r1.61 configure.in
*** configure.in 2001/03/23 16:05:29 1.61
--- configure.in 2001/03/28 21:29:25
*************** fi
*** 652,661 ****
# NOTE: If you add to this list, remember to update
# gdb/doc/gdbint.texinfo.
build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
! -Wformat -Wparentheses -Wpointer-arith"
# Up for debate: -Wswitch -Wcomment -trigraphs -Wtrigraphs
# -Wunused-function -Wunused-label -Wunused-variable -Wunused-value
! # -Wchar-subscripts -Wuninitialized -Wtraditional -Wshadow -Wcast-qual
# -Wcast-align -Wwrite-strings -Wconversion -Wstrict-prototypes
# -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls
# -Woverloaded-virtual -Winline -Werror"
--- 652,661 ----
# NOTE: If you add to this list, remember to update
# gdb/doc/gdbint.texinfo.
build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
! -Wformat -Wparentheses -Wpointer-arith -Wuninitialized"
# Up for debate: -Wswitch -Wcomment -trigraphs -Wtrigraphs
# -Wunused-function -Wunused-label -Wunused-variable -Wunused-value
! # -Wchar-subscripts -Wtraditional -Wshadow -Wcast-qual
# -Wcast-align -Wwrite-strings -Wconversion -Wstrict-prototypes
# -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls
# -Woverloaded-virtual -Winline -Werror"
Index: dsrec.c
===================================================================
RCS file: /cvs/src/src/gdb/dsrec.c,v
retrieving revision 1.8
diff -p -r1.8 dsrec.c
*** dsrec.c 2001/03/06 08:21:06 1.8
--- dsrec.c 2001/03/28 21:29:25
*************** make_srec (char *srec, CORE_ADDR targ_ad
*** 242,247 ****
--- 242,248 ----
{
tmp = flags >> SREC_TERM_SHIFT; /* Term record */
code_table = term_code_table;
+ binbuf = NULL;
}
if ((tmp & SREC_2_BYTE_ADDR) && (targ_addr <= 0xffff))
Index: mcore-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mcore-tdep.c,v
retrieving revision 1.8
diff -p -r1.8 mcore-tdep.c
*** mcore-tdep.c 2001/03/06 08:21:10 1.8
--- mcore-tdep.c 2001/03/28 21:29:26
*************** mcore_analyze_prologue (struct frame_inf
*** 251,257 ****
CORE_ADDR func_addr, func_end, addr, stop;
CORE_ADDR stack_size;
int insn, rn;
! int status, fp_regnum, flags;
int framesize;
int register_offsets[NUM_REGS];
char *name;
--- 251,259 ----
CORE_ADDR func_addr, func_end, addr, stop;
CORE_ADDR stack_size;
int insn, rn;
! int status;
! int fp_regnum = 0; /* dummy, valid when (flags & MY_FRAME_IN_FP) */
! int flags;
int framesize;
int register_offsets[NUM_REGS];
char *name;
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.46
diff -p -r1.46 mips-tdep.c
*** mips-tdep.c 2001/03/26 04:01:53 1.46
--- mips-tdep.c 2001/03/28 21:29:30
*************** show_mipsfpu_command (char *args, int fr
*** 3292,3297 ****
--- 3292,3299 ----
case MIPS_FPU_NONE:
fpu = "absent (none)";
break;
+ default:
+ internal_error (__FILE__, __LINE__, "bad switch");
}
if (mips_fpu_type_auto)
printf_unfiltered ("The MIPS floating-point coprocessor is set automatically (currently %s)\n",
*************** mips_dump_tdep (struct gdbarch *current_
*** 4157,4165 ****
ef_mips_arch = 3;
break;
case E_MIPS_ARCH_4:
! ef_mips_arch = 0;
break;
default:
break;
}
/* determine the size of a pointer */
--- 4159,4168 ----
ef_mips_arch = 3;
break;
case E_MIPS_ARCH_4:
! ef_mips_arch = 4;
break;
default:
+ ef_mips_arch = 0;
break;
}
/* determine the size of a pointer */
Index: mn10200-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10200-tdep.c,v
retrieving revision 1.5
diff -p -r1.5 mn10200-tdep.c
*** mn10200-tdep.c 2001/03/06 08:21:10 1.5
--- mn10200-tdep.c 2001/03/28 21:29:33
*************** static CORE_ADDR
*** 114,120 ****
mn10200_analyze_prologue (struct frame_info *fi, CORE_ADDR pc)
{
CORE_ADDR func_addr, func_end, addr, stop;
! CORE_ADDR stack_size;
unsigned char buf[4];
int status;
char *name;
--- 114,120 ----
mn10200_analyze_prologue (struct frame_info *fi, CORE_ADDR pc)
{
CORE_ADDR func_addr, func_end, addr, stop;
! CORE_ADDR stack_size = 0;
unsigned char buf[4];
int status;
char *name;
Index: monitor.c
===================================================================
RCS file: /cvs/src/src/gdb/monitor.c,v
retrieving revision 1.21
diff -p -r1.21 monitor.c
*** monitor.c 2001/03/06 08:21:10 1.21
--- monitor.c 2001/03/28 21:29:34
*************** monitor_read_memory_single (CORE_ADDR me
*** 1691,1697 ****
char membuf[sizeof (int) * 2 + 1];
char *p;
char *cmd;
- int i;
monitor_debug ("MON read single\n");
#if 0
--- 1691,1696 ----
*************** monitor_read_memory_single (CORE_ADDR me
*** 1751,1779 ****
else
monitor_error ("monitor_read_memory_single",
"bad response from monitor",
! memaddr, i, membuf, c);
}
- for (i = 0; i < len * 2; i++)
- {
- int c;
! while (1)
! {
! c = readchar (timeout);
! if (isxdigit (c))
! break;
! if (c == ' ')
! continue;
!
! monitor_error ("monitor_read_memory_single",
! "bad response from monitor",
! memaddr, i, membuf, c);
! }
!
membuf[i] = c;
}
!
! membuf[i] = '\000'; /* terminate the number */
/* If TERM is present, we wait for that to show up. Also, (if TERM is
present), we will send TERM_CMD if that is present. In any case, we collect
--- 1750,1780 ----
else
monitor_error ("monitor_read_memory_single",
"bad response from monitor",
! memaddr, 0, NULL, 0);
}
! {
! int i;
! for (i = 0; i < len * 2; i++)
! {
! int c;
!
! while (1)
! {
! c = readchar (timeout);
! if (isxdigit (c))
! break;
! if (c == ' ')
! continue;
!
! monitor_error ("monitor_read_memory_single",
! "bad response from monitor",
! memaddr, i, membuf, 0);
! }
membuf[i] = c;
}
! membuf[i] = '\000'; /* terminate the number */
! }
/* If TERM is present, we wait for that to show up. Also, (if TERM is
present), we will send TERM_CMD if that is present. In any case, we collect
Index: sh-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-tdep.c,v
retrieving revision 1.32
diff -p -r1.32 sh-tdep.c
*** sh-tdep.c 2001/03/06 08:21:16 1.32
--- sh-tdep.c 2001/03/28 21:29:36
*************** sh_do_fp_register (int regnum)
*** 1766,1772 ****
print_spaces_filtered (15 - strlen (REGISTER_NAME (regnum)), gdb_stdout);
/* Print the value. */
! printf_filtered (inv ? "<invalid float>" : "%-10.9g", flt);
/* Print the fp register as hex. */
printf_filtered ("\t(raw 0x");
--- 1766,1775 ----
print_spaces_filtered (15 - strlen (REGISTER_NAME (regnum)), gdb_stdout);
/* Print the value. */
! if (inv)
! printf_filtered ("<invalid float>");
! else
! printf_filtered ("%-10.9g", flt);
/* Print the fp register as hex. */
printf_filtered ("\t(raw 0x");
Index: sparc-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-tdep.c,v
retrieving revision 1.15
diff -p -r1.15 sparc-tdep.c
*** sparc-tdep.c 2001/03/06 08:21:17 1.15
--- sparc-tdep.c 2001/03/28 21:29:53
*************** sparc64_push_arguments (int nargs, value
*** 2381,2386 ****
--- 2381,2388 ----
fpreg = FP0_REGNUM + 2 * register_counter;
register_counter += 2;
break;
+ default:
+ internal_error (__FILE__, __LINE__, "bad switch");
}
write_register_bytes (REGISTER_BYTE (fpreg),
VALUE_CONTENTS (args[i]),
Index: v850-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/v850-tdep.c,v
retrieving revision 1.9
diff -p -r1.9 v850-tdep.c
*** v850-tdep.c 2001/03/06 08:21:18 1.9
--- v850-tdep.c 2001/03/28 21:29:53
*************** v850_scan_prologue (CORE_ADDR pc, struct
*** 356,362 ****
for (current_pc = func_addr; current_pc < prologue_end;)
{
! int insn, insn2;
#ifdef DEBUG
printf_filtered ("0x%.8lx ", (long) current_pc);
--- 356,363 ----
for (current_pc = func_addr; current_pc < prologue_end;)
{
! int insn;
! int insn2 = -1; /* dummy value */
#ifdef DEBUG
printf_filtered ("0x%.8lx ", (long) current_pc);