This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] monitor.c fix for rom68k target boards
- To: Jeff Holcomb <jeffh at redhat dot com>
- Subject: Re: [RFA] monitor.c fix for rom68k target boards
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Wed, 04 Apr 2001 16:53:45 -0400
- Cc: gdb-patches at sources dot redhat dot com
- References: <Pine.SOL.3.91.1010402165500.747F-100000@cse.cygnus.com>
> A possibility would be to change the test back to the original version
> rather than removing the test, like:
>
> if (val == 0 && valstr == p)
> error ("monitor_supply_register (%d): bad value from monitor: %s.",
> regno, valstr);
Yes, that sounds better. I think the function should still fail if it
does nothing - that would tend to suggest some sort of real problem with
the monitor.
> I'm willing to go either way, I just don't know what the intent was in
> changing the if test.
I don't think it was intentional. Any way, assume your patch is
approved with the tweeked test.
enjoy,
Andrew