This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Add support for tracking/evaluating dwarf2 location expressions
- To: Daniel Berlin <dan at www dot cgsoftware dot com>
- Subject: Re: [PATCH] Add support for tracking/evaluating dwarf2 location expressions
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Fri, 6 Apr 2001 12:35:32 -0700
- Cc: Andrew Cagney <ac131313 at cygnus dot com>, <gdb-patches at sources dot redhat dot com>, Daniel Berlin <dberlin at redhat dot com>
- References: <Pine.LNX.4.33.0104061508410.1542-100000@www.cgsoftware.com>
On Apr 6, 3:10pm, Daniel Berlin wrote:
> On Fri, 6 Apr 2001, Andrew Cagney wrote:
>
> > > > value_ptr stack[64];
> > > > Is there a constant for this? A quick glance at decode_locdesc() and it
> > > > has the same hardwired constant.
> > > Nobody has ever produced location expressions that need more.
> >
> > The problem typically isn't with what people are doing intentionally but
> > rather unintentionally. The code opens the way for an input file to
> > cause gdb to overflow a buffer and trash its stack.
>
> Well, as I said, it will trash GCC as well, since they do no range
> checking, and have the exact same limit.
> But i'll range check it, just the same.
Maybe GCC has been designed so that it'll never need a bigger stack.
But keep in mind that GDB needs to accept as input the output of
compilers other than GCC. Perhaps some other compiler, through either
a bug or a feature, will produce more complicated location expressions
than GCC.
Anyway, I'm glad you've added the range check.
Kevin