This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: [symfile.c} Fix to symbol_file_add() [REPOST]
Elena Zannoni wrote:
>
> Fernando Nasser writes:
> > Elena Zannoni wrote:
> > >
> > > Thanks Fernando!
> > > But shouldn't we be leaving the stuff in symbol_file_command?
> > > I.e. only adding it to the new function?
> > >
> >
> > Yes, of course. It calls symbol_file_add(), not symbol_file_add_main()
> > because of the flags. Silly me.
> >
> > Yes, please consider the patch without the removal part.
>
> Ok, sure. Check it in. Just for completion can you post the final
> diff once you are done?
>
Absolutely.
> Thanks
> Elena
>
> >
> > P.S.: I guess symbol_file_add_main() should have the flags argument,
> > but I guess this thing has been going on for too long now for me to go
> > after all callers and add the argument.
>
> Add a FIXME/comment.
>
Good idea.
Thank you for all your help.
P.S.: I will have to do all this tomorrow afternoon as I have to prepare
a presentation.
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9