This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Remove OS-specific defines (was: _WIN32?)
- To: gdb-patches at sources dot redhat dot com
- Subject: Re: [RFA] Remove OS-specific defines (was: _WIN32?)
- From: "Eli Zaretskii" <eliz at is dot elta dot co dot il>
- Date: Mon, 07 May 2001 21:24:53 +0300
- References: <20010503211502.21716.qmail@web6401.mail.yahoo.com> <3AF1DAA0.3060702@cygnus.com> <200105071610.TAA24144@is.elta.co.il> <1010507173855.ZM18890@ocotillo.lan>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
I see that I sent the original RFA to a wrong address. Sorry, I will
resend.
Here's my reply to Kevin's approval:
> Date: Mon, 7 May 2001 10:38:55 -0700
> From: Kevin Buettner <kevinb@cygnus.com>
>
> On May 7, 7:10pm, Eli Zaretskii wrote:
>
> > * solib.c (solib_open): Use IS_DIR_SEPARATOR and IS_ABSOLUTE_PATH
> > instead of SLASH_CHAR, ROOTED_P and SLASH_P.
> > (top-level): #include "filenames.h".
>
> Your changes to solib.c are approved. (FWIW, I glanced over your
> changes to the other files and they look good too.)
Thanks for reviewing them so soon.
> Don't forget to also remove the definitions of SLASH_P, SLASH_CHAR, and
> ROOTED_P in config/i386/xm-cygwin.h and config/i386/xm-go32.h.
Yes, it's in the pipeline ;-) I just wanted to hear from Chris, at
the very least, before futzing with his files.
Btw, is it perhaps a good idea to add to gdbint.texinfo some
guidelines about writing portable code which handles file names,
including the list of these macros? Andrew?