This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Fix argumens to return_value_location
- To: Jim Blandy <jimb at cygnus dot com>
- Subject: Re: [RFA] Fix argumens to return_value_location
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Thu, 10 May 2001 00:14:37 -0400
- Cc: gdb-patches at sources dot redhat dot com
- References: <20010411203745.25B9E5E9CB@zwingli.cygnus.com>
> 2001-04-11 Jim Blandy <jimb@redhat.com>
>
> * mips-tdep.c (return_value_location): Swap `hi' and `lo'
> arguments, to match the way this function is actually called.
Can you instead change the calls to read &hi, &lo? It's probably a
personal thing I prefer big endian orderings - hi before lo :-)
Looking at the code, I think it managed to bumble its way through almost
all the different cases anyway.
anyway, either way, thanks,
Andrew
> Index: gdb/mips-tdep.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/mips-tdep.c,v
> retrieving revision 1.248.2.1
> diff -c -r1.248.2.1 mips-tdep.c
> *** gdb/mips-tdep.c 2001/01/25 08:31:40 1.248.2.1
> --- gdb/mips-tdep.c 2001/04/11 20:24:22
> ***************
> *** 3082,3089 ****
>
> static void
> return_value_location (struct type *valtype,
> ! struct return_value_word *hi,
> ! struct return_value_word *lo)
> {
> int len = TYPE_LENGTH (valtype);
>
> --- 3082,3089 ----
>
> static void
> return_value_location (struct type *valtype,
> ! struct return_value_word *lo,
> ! struct return_value_word *hi)
> {
> int len = TYPE_LENGTH (valtype);
>