This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA] breakpoint.c: Pass breakpoint type to set_raw_breakpoint()
- To: Michael Snyder <msnyder at cygnus dot com>
- Subject: Re: [PATCH RFA] breakpoint.c: Pass breakpoint type to set_raw_breakpoint()
- From: Fernando Nasser <fnasser at redhat dot com>
- Date: Fri, 11 May 2001 13:27:47 -0400
- CC: Kevin Buettner <kevinb at cygnus dot com>, Jim Blandy <jimb at cygnus dot com>, gdb-patches at sources dot redhat dot com, Keith Seitz <keiths at cygnus dot com>
- Organization: Red Hat Canada
- References: <1010511075057.ZM27226@ocotillo.lan> <3AFC1ED7.9458AEE1@cygnus.com>
Michael Snyder wrote:
>
> Kevin, I like it, but I noticed that set_raw_breakpoint is not static.
> It was made extern in 1998, and is used by gdbtk-cmds.c.
>
> Can you check to see if that call needs a bp_type argument, and if that
> call can't be eliminated, maybe you should add a prototype to breakpoint.h.
>
I believe it can be made static now. I don't think anyone should be
using it outside breakpoint.c.
Keith, does your new gdbtk-bp.c uses this function?
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9