This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] solib-osf.c: reimplement osfsolib.c as solib.c backend
- To: Nick Duffek <nsd at redhat dot com>
- Subject: Re: [RFA] solib-osf.c: reimplement osfsolib.c as solib.c backend
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Fri, 25 May 2001 16:32:58 -0700
- Cc: gdb-patches at sources dot redhat dot com
- References: <200105250215.f4P2FCs07063@rtl.cygnus.com>
On May 24, 10:15pm, Nick Duffek wrote:
> The appended patch reimplements osfsolib.c as a back end to the generic
> shared library support framework in solib.c.
>
> For consistency with other such back ends, I renamed it to solib-osf.c.
>
> ChangeLog:
>
> * Makefile.in (osfsolib.c, osfsolib.o): Rename to solib-osf.c and
> solib-osf.o.
> * config/alpha/alpha-osf1.mh (NATDEPFILES): Replace osfsolib.o
> with solib-osf.o and solib.o.
> * config/alpha/alpha-osf2.mh: Likewise.
> * config/alpha/alpha-osf3.mh: Likewise.
> * solib-osf.c: New file, renamed and largely rewritten from
> osfsolib.c.
>
> Tested on alphaev6-dec-osf5.1 and alpha-dec-osf4.0 with preceding patch to
> solib.c. Okay to apply?
Yes, approved. (I *can* approve this, can't I?)
A couple of comments though...
1) I see some code disabled with #if 0 in solib-osf.c. Is there a
reason for retaining this code? (I did read your comment and if
you think someone might want to reenable ldr_read_memory() at some
time in the future, then by all means keep it.)
2) _initialize_osf_solib() should probably have an extern declaration
at the top of the file. I realize that this shouldn't be necessary,
but it eliminates the warning when using -Wmissing-prototypes.
Kevin