This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] mips32_next_pc overdue cleanup
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: [RFA] mips32_next_pc overdue cleanup
- From: Daniel Jacobowitz <dmj+ at andrew dot cmu dot edu>
- Date: Thu, 5 Jul 2001 22:37:17 -0700
- Cc: gdb-patches at sources dot redhat dot com
- References: <20010704114147.A15695@nevyn.them.org> <3B454B1B.7040506@cygnus.com>
On Fri, Jul 06, 2001 at 01:22:35AM -0400, Andrew Cagney wrote:
> > This patch is half style cleanups and half obvious fixes, but there's so
> > many I'd appreciate more eyes. According to the masks in the opcodes
> > directory, these changes are rigt, and what we had before can't possibly
> > work. Especially the fact that we would never, ever predict a BNE as taken
> > before these changes convinced me that they really were correct and this
> > code had never been particularly tested. Comments?
>
>
> Approved.
And committed.
> History? It pre-dates my MIPS hacking :-) Dig dig, ah, it started out
> as part of some prototyping that wasn't finished It was added in '98.
> The WinCE GDB port ended up using it so I suspect it was made to mostly
> work. The main reason the code worked is because it didn't bother to
> use the broken macros that were added at the same time as the original
> code :-/
So I noticed :) I'm guessing that it either got a breath of life in
2000, or someone just happened to notice a mistake and was inspired.
Well, now it'll get some checking.
Now all the major patches for the Linux port are in! A small style
tweak and a NEWS entry, and I consider it ready to commit.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer