This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: gdb run < file


Hi Chris,

I have signed an assignment before, when I made an Emacs lisp package
contribution.  I guess that has nothing to do with this one.  BTW, is
that gdb patch large enough requiring an assignment?  Can it be a
simpler disclaim?  In either case I am happy to do it because I don't
want to lose that feature in the next release of gdb.

Anyway, I think I need to be contacted from gdb maintainer to be
hooked up with an FSF lawyer.  Last time, the Emacs maintainer Gerd
Moellmann had set me up such an arrangement.

-Tak

-----Original Message-----
From: Christopher Faylor <cgf@redhat.com>
Date: Wed, 10 Oct 2001 22:36:44 -0400
Subject: Re: gdb run < file

> [message redirected to gdb-patches]
> On Sat, Jun 30, 2001 at 10:20:24PM -0700, Tak Ota wrote:
> >This is much simpler and cleaner than the previous attempt.  And it is
> >the *CORRECT* implementation from UNIX point of view.  The existence
> >of "SHELL" environment variable does not necessarily guaranty that it
> >is usable for this purpose.  This needs to be improved.
> 
> Hello, Tak,
> I was wondering if you had made any progress with assigning your gdb
> changes to the FSF.
> 
> I would like to get these changes into gdb as this is a much-requested
> feature but we need to go through the necessary legalities first.
> 
> I think we may have only mentioned that assigning your changes to the
> FSF this was necessary in passing so it may not have been obvious that
> you needed to do this.  However, AFAICT you haven't signed an assignment
> with the FSF.
> 
> This link: http://sources.redhat.com/gdb/contribute/ has more information
> about what you need to do next should you choose to submit your patch.
> 
> I'm sorry that it has taken me so long to check up on this.  I've been
> using your changes for the last couple of months and I just forgot that
> they hadn't been applied until I made some recent changes to win32-nat.c.
> 
> cgf
> 
> >
> >*** win32-nat.org.c	Wed Apr 18 13:27:11 2001
> >--- win32-nat.c	Sat Jun 30 21:59:29 2001
> >***************
> >*** 1084,1090 ****
> >  static void
> >  child_create_inferior (char *exec_file, char *allargs, char **env)
> >  {
> >!   char real_path[MAXPATHLEN];
> >    char *winenv;
> >    char *temp;
> >    int envlen;
> >--- 1084,1090 ----
> >  static void
> >  child_create_inferior (char *exec_file, char *allargs, char **env)
> >  {
> >!   char *shell;
> >    char *winenv;
> >    char *temp;
> >    int envlen;
> >***************
> >*** 1101,1108 ****
> >    memset (&si, 0, sizeof (si));
> >    si.cb = sizeof (si);
> >  
> >-   cygwin_conv_to_win32_path (exec_file, real_path);
> >- 
> >    flags = DEBUG_ONLY_THIS_PROCESS;
> >  
> >    if (new_group)
> >--- 1101,1106 ----
> >***************
> >*** 1111,1122 ****
> >    if (new_console)
> >      flags |= CREATE_NEW_CONSOLE;
> >  
> >!   args = alloca (strlen (real_path) + strlen (allargs) + 2);
> >! 
> >!   strcpy (args, real_path);
> >! 
> >!   strcat (args, " ");
> >!   strcat (args, allargs);
> >  
> >    /* Prepare the environment vars for CreateProcess.  */
> >    {
> >--- 1109,1132 ----
> >    if (new_console)
> >      flags |= CREATE_NEW_CONSOLE;
> >  
> >!   shell = getenv ("SHELL");
> >!   if (shell)
> >!     {
> >!       char *exec_format = "%s -c 'exec %s %s'";
> >! 
> >!       args = alloca (strlen (exec_format) + strlen (shell) + strlen (exec_file) + strlen (allargs));
> >!       sprintf(args, exec_format, shell, exec_file, allargs);
> >!     }
> >!   else
> >!     {
> >!       char real_path[MAXPATHLEN];
> >! 
> >!       cygwin_conv_to_win32_path (exec_file, real_path);
> >!       args = alloca (strlen (real_path) + strlen (allargs) + 2);
> >!       strcpy (args, real_path);
> >!       strcat (args, " ");
> >!       strcat (args, allargs);
> >!     }
> >  
> >    /* Prepare the environment vars for CreateProcess.  */
> >    {
> 
> -- 
> cgf@cygnus.com                        Red Hat, Inc.
> http://sources.redhat.com/            http://www.redhat.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]