This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/c++] Fix printing classes with virtual base classes

On Nov 26,  9:02pm, Daniel Jacobowitz wrote:

> On Mon, Nov 26, 2001 at 08:19:45PM -0500, Daniel Jacobowitz wrote:
> > Whew.  Finally tracked this down.
> 
> [snip correct explanation]
> 
> [snip incorrect patch]
> 
> I find the use of VALUE_OFFSET and VALUE_EMBEDDED_OFFSET exceedingly
> unintuitive.  Go figure.  This one works a little bit better yet.
> 
> -- 
> Daniel Jacobowitz                           Carnegie Mellon University
> MontaVista Software                         Debian GNU/Linux Developer
> 
> 2001-11-26  Daniel Jacobowitz  <drow@mvista.com>
> 
>         * gnu-v3-abi.c (gnuv3_rtti_type): Explicitly cast
>         the vtable pointer to a pointer before loading it.
>         (gnuv3_virtual_fn_field): Likewise.

I don't have any comments on Daniel's patch, but I am wondering who
will approve this.  Given that we currently have no C++ maintainer,
should we treat Daniel's patch as an RFC and have him commit it after
a few days if there are no objections?

Kevin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]