This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: gdb-patches <gdb-patches at sources dot redhat dot com>
- Date: Wed, 5 Dec 2001 20:25:07 +0100
- Subject: [RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info
- Reply-to: gdb-patches <gdb-patches at sources dot redhat dot com>
Hi,
the first test in a2-bin.exp checks if the return code is 1 when
the application is called w/o parameter. Unfortunately there are
(remote) targets which aren't able to return a return code so that
the return code is always set to 0. That results in a failing
first test in a2-bin.exp even though the target is doing the right
thing.
To indicate that a target can't return a return code, there's
a setting `set_board_info needs_status_wrapper 1' which just
isn't taken into account in a2-bin.exp.
The following patch changes that.
Corinna
2001-12-05 Corinna Vinschen <vinschen@redhat.com>
* gdb.base/a2-bin.exp: Pass first test even if the return
code is 0 if target_info `needs_status_wrapper' exists.
Index: a2-run.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/a2-run.exp,v
retrieving revision 1.3
diff -u -p -r1.3 a2-run.exp
--- a2-run.exp 2001/03/06 08:21:50 1.3
+++ a2-run.exp 2001/12/05 19:10:31
@@ -80,6 +80,13 @@ if [istarget "*-*-vxworks*"] then {
-re ".*usage: factorial <number>.*Program exited with code 01.*$gdb_prompt $" {
pass "run \"$testfile\" with no args"
}
+ -re ".*usage: factorial <number>.*Program exited normally.*$gdb_prompt $" {
+ if [target_info exists needs_status_wrapper] then {
+ pass "run \"$testfile\" with no args"
+ } else {
+ fail "run \"$testfile\" with no args"
+ }
+ }
-re ".*$gdb_prompt $" {
fail "run \"$testfile\" with no args"
verbose "expect_out is $expect_out(buffer)" 2
--
Corinna Vinschen
Red Hat, Inc.
mailto:vinschen@redhat.com