This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: don't set timeout for all boards in break.exp
- From: Jim Blandy <jimb at zwingli dot cygnus dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: 07 Dec 2001 16:04:04 -0500
- Subject: Re: RFA: don't set timeout for all boards in break.exp
- References: <20010918215339.788315E9D8@zwingli.cygnus.com>
I've committed this.
Jim Blandy <jimb@cygnus.com> writes:
>
> I'm sure there are more of these patches to come...
>
> 2001-09-18 Jim Blandy <jimb@redhat.com>
>
> * gdb.base/break.exp: (test_next_with_recursion): Don't change the
> value of `timeout' for targets other than the mips*tx39-*.
>
> Index: gdb/testsuite/gdb.base/break.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
> retrieving revision 1.8
> diff -c -r1.8 break.exp
> *** gdb/testsuite/gdb.base/break.exp 2001/03/06 08:21:50 1.8
> --- gdb/testsuite/gdb.base/break.exp 2001/09/18 21:50:02
> ***************
> *** 783,791 ****
>
> if [istarget "mips*tx39-*"] {
> set timeout 60
> - } else {
> - set timeout 20
> }
>
> gdb_test next "\[0-9\]*\[\t \]+return \\(value\\);.*" \
> "next over recursive call"
> --- 783,801 ----
>
> if [istarget "mips*tx39-*"] {
> set timeout 60
> }
> + # We used to set timeout here for all other targets as well. This
> + # is almost certainly wrong. The proper timeout depends on the
> + # target system in use, and how we communicate with it, so there
> + # is no single value appropriate for all targets. The timeout
> + # should be established by the Dejagnu config file(s) for the
> + # board, and respected by the test suite.
> + #
> + # For example, if I'm running GDB over an SSH tunnel talking to a
> + # portmaster in California talking to an ancient 68k board running
> + # a crummy ROM monitor (a situation I can only wish were
> + # hypothetical), then I need a large timeout. But that's not the
> + # kind of knowledge that belongs in this file.
>
> gdb_test next "\[0-9\]*\[\t \]+return \\(value\\);.*" \
> "next over recursive call"
>