This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] include sim/common/sim-fpu.c in PSIM.


>> hi folks.
>> 
>> 
>> this patch enables the use of sim-fpu.c FP functions inside PSIM.
>> not included are any changes to use these functions, merely the
>> infrastructure work required.  as many macros conflicted with
>> sim-common, i had to rename many psim macros.  the name changes
>> are either of the form s/SIM/PSIM/ or s/^/PSIM_/.
>> 
>> i have verified that both gdb & psim tests work equally with
>> or without this patch.
>> 
>> 
>> OK?
> 
> 
Fine with the theory.   I'd like to be able to use sim-fpu.[hc] from GDB as well so the more sim/common is broken down and simplified the better.  This is hopefully helping.
 
One concern is with the Makefile.in change.  From memory your ment to use $(srcdir)/../..... and $< isn't a good idea either - check Ben Harris's recent changes to gdb's Makefile.in.

BTW, don't forget to chomp out the changes to the generated configure file when posting the patch.

	Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]