This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Patch: completion -vs- duplicates
- From: "Eli Zaretskii" <eliz at is dot elta dot co dot il>
- To: tromey at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 05 Jan 2002 10:22:26 +0200
- Subject: Re: Patch: completion -vs- duplicates
- References: <877kqx7j8o.fsf@creche.redhat.com>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> From: Tom Tromey <tromey@redhat.com>
> Date: 04 Jan 2002 17:07:51 -0700
>
> Right now the `complete' command can print duplicates. readline seems
> to filter these, so you don't see this using Tab in the CLI, but you
> can see it in Insight or by using the complete command.
Hm... shouldn't Insight do the same as readline?
In my mind, GDB doesn't do any completion at all. Completion is a
feature of the UI; GDB just helps the UI by providing a function to
call to get all the completion candidates. The rest--how to display
the candidates, whether to filter out duplicates, etc.--is up to the
UI's completion machinery. So conceptually, in my mind, the
filtering doesn't belong in GDB.
Concepts aside, the change you suggest has also practical
disadvantages: filtering duplicates in GDB's completion function would
mean a performance hit in the CLI version, since readline will try to
filter again.