This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: ARM simulator coredump


> +	  int ok = state->CPRead[14] (state, 0, &cp14r0);

As a coding nit, I can't say I'm madly keen on a variable that's called 
"ok".  At any point other than its assignment, it isn't going to be very 
clear what is "ok".  This variable is used over more than 50 lines of code 
which, at least for me, means that I won't be able to see the assignment 
at the same time as it's final use.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]