This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/testsuite] Fix completion.exp on relative srcdir path
On Thu, Jan 10, 2002 at 09:43:34PM -0500, Jim Blandy wrote:
>
> Daniel Jacobowitz <drow@mvista.com> writes:
> > I always configure with relative paths - srcdir = ../../../src/gdb/testsuite
> > or so. That caused a bogus failure. Is this patch OK?
>
> What's behind the `cd ${objdir}' there that you're not doing anything
> with? Is the patch incomplete, or does it need to be cleaned up?
>
> If you address that, and add a comment explaining why what you're
> doing is necessary, then this patch looks good.
${srcdir} is a relative path - it starts with a '.'. Objdir is known
(IIRC) to be an absolute path. I'm reasonably sure that pwd will
always be objdir at this point, but not certain. It might still work
if I remove that line, though. I'll check.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer