This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: bugfix gdb5.0/insight5.0
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Grant Edwards <grante at visi dot com>,Fernando Nasser <fnasser at redhat dot com>,Scott Bambrough <sbambrough at zimismobile dot com>
- Cc: Jan Van Belle <Jan dot Van_Belle at alcatel dot be>,Jan_VAN_BELLE/BE/ALCATEL at ALCATEL dot visi dot com,gdb-patches at sources dot redhat dot com
- Date: Sun, 20 Jan 2002 17:47:19 -0500
- Subject: Re: bugfix gdb5.0/insight5.0
- References: <3C108A1A.561C7AF7@alcatel.be> <20011207084414.A574@visi.com>
> On Fri, Dec 07, 2001 at 10:21:30AM +0100, Jan Van Belle wrote:
>
>
>> for those compiling for target arm-elf, I have a small bugfix at
>> compile-time.
>>
>> remove: struct tm lt;
>>
>> in two functions. (openLog() and closeLog() or something. It are the
>> first two functions in the file).
>>
>> in file: xxx/xxx5.0/gdb/rdi-share/devsw.c
>>
>> Otherwise I got: struct tm : size not known.
>> struct tm is declared in the two functions but not called in any way...
>
>
> I see time.h was included a while back to get rid of the
> warning, but it looks like Mr. Van Belle is right, the stuct is
> never used, so both the declaration and the include of time.h
> should be removed.
Almost, <time.h> is also needed for time_t and time().
Since no one else moved on this, I took the liberty of removing the two
two struct decls.
enjoy,
Andrew
2002-01-20 Andrew Cagney <ac131313@redhat.com>
* rdi-share/devsw.c (openLogFile): Delete unused ``struct tm lt''.
(closeLogFile): Ditto.
Index: rdi-share/devsw.c
===================================================================
RCS file: /cvs/src/src/gdb/rdi-share/devsw.c,v
retrieving revision 1.2
diff -p -r1.2 devsw.c
*** devsw.c 2001/05/03 13:41:17 1.2
--- devsw.c 2002/01/20 22:43:34
*************** static int angelDebugLogEnable = 0;
*** 37,43 ****
static void openLogFile ()
{
time_t t;
- struct tm lt;
if (angelDebugFilename == NULL || *angelDebugFilename =='\0')
return;
--- 37,42 ----
*************** static void openLogFile ()
*** 67,73 ****
static void closeLogFile (void)
{
time_t t;
- struct tm lt;
if (!angelDebugLogFile)
return;
--- 66,71 ----