This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: complete -vs- duplicates, take 2


> Date: Fri, 25 Jan 2002 10:39:31 -0500
> From: Fernando Nasser <fnasser@redhat.com>
> 
> It looks OK for me, but I would like Eli's opinion as he is the one who
> has spent more time fixing the completer lately.
> 
> Eli?

Tom's idea is okay with me, but I have difficulty reviewing the patch,
because Diff made a terrible salad out of it, probably due to some
false matches in wrong places.

Tom, could you please play with different values of context line
numbers (the NUM parameter in "diff -U NUM"), to produce diffs for
completer.c that would show the real changes, and post just that part
of the patch?  (I tried to apply your patch and then produce better
diffs myself, but the patch didn't apply, probably because of version
mismatch between my sources and youirs.)

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]