Re: RFC/PATCH Fix some timeouts in the testsuite

[Fernando Nasser <fnasser at redhat dot com>]

Richard Earnshaw wrote:
> 
> The way that some of the tests are written, particularly in
> gdb.base/defaults.exp mean that my poor little test machine can't complete
> some of the reg-exp matches in the time available.  This then snowballs in
> that the tests seem to get desyncronized and several tests after the
> initial timeout will then also time out.  Rather than bumping the
> timeouts, I've rewritten some of the patterns to reduce the time taken to
> match them.  This results from the fact that expect is very poor at
> matching multiple ".*\[\r\n]+" sequences in a regexp, but is no-where near
> as bad for the sequence "(\[^\r\n\]*\[\r\n\])+" and which is equally good
> in these tests.  The result of this change is to shave about 5 minutes off
> the time to execute gdb.base/defaults.exp and to remove all the failures
> (all timeouts) that I was seeing.
> 
> OK to apply?
> 

Yes.

Thank you for the performance improvement patch.

Regards,
Fernando


> If this is acceptable I'll have a look at some of the other tests to see
> if they can also benefit from this trick.
> 
> R.
> 
> <date>  Richard Earnshaw  (rearnsha@arm.com)
> 
>         * gdb.base/defaults.exp: Rewrite test patterns to reduce time
>         taken to match them.
> 
>   ------------------------------------------------------------------------
>                            Name: gdb-testdef.patch
>    gdb-testdef.patch       Type: text/x-patch
>                     Description: gdb-testdef.patch

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9