This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] regcache pseudo-reg tweak



Andrew, 

I think you left out an "else" when you made this change in december.
We must not call target_[fetch/store]_register with a pseudo-register, 
or they will choke.  By definition, a pseudo-register is one that 
cannot be fetched from the target.

Remote_fetch_register, for instance, aborts on this.

Michael

2002-02-05  Michael Snyder  <msnyder@redhat.com>

	* regcache.c (fetch_register): Don't call target_fetch_register
	for a pseudo_register.
	(store_register): Don't call target_store_register for a
	pseudo_register.

Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.31
diff -c -3 -p -r1.31 regcache.c
*** regcache.c	2002/01/29 20:24:27	1.31
--- regcache.c	2002/02/06 02:30:46
*************** fetch_register (int regnum)
*** 125,131 ****
    if (FETCH_PSEUDO_REGISTER_P ()
        && pseudo_register (regnum))
      FETCH_PSEUDO_REGISTER (regnum);
!   target_fetch_registers (regnum);
  }
  
  /* Write register REGNUM cached value to the target.  */
--- 125,132 ----
    if (FETCH_PSEUDO_REGISTER_P ()
        && pseudo_register (regnum))
      FETCH_PSEUDO_REGISTER (regnum);
!   else if (real_register (regnum))
!     target_fetch_registers (regnum);
  }
  
  /* Write register REGNUM cached value to the target.  */
*************** store_register (int regnum)
*** 140,146 ****
    if (STORE_PSEUDO_REGISTER_P ()
        && pseudo_register (regnum))
      STORE_PSEUDO_REGISTER (regnum);
!   target_store_registers (regnum);
  }
  
  /* Low level examining and depositing of registers.
--- 141,148 ----
    if (STORE_PSEUDO_REGISTER_P ()
        && pseudo_register (regnum))
      STORE_PSEUDO_REGISTER (regnum);
!   else if (real_register (regnum))
!     target_store_registers (regnum);
  }
  
  /* Low level examining and depositing of registers.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]