This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] fix for utils.c bool problem
On Thu, Feb 07, 2002 at 05:01:37PM -0500, Andrew Cagney wrote:
> Martin,
>
>
>
> @@ -20,18 +20,18 @@
> Foundation, Inc., 59 Temple Place - Suite 330,
> Boston, MA 02111-1307, USA. */
>
> -#include "defs.h"
> -#include "gdb_assert.h"
> -#include <ctype.h>
> -#include "gdb_string.h"
> -#include "event-top.h"
> -
> #ifdef HAVE_CURSES_H
> #include <curses.h>
> #endif
> #ifdef HAVE_TERM_H
> #include <term.h>
> #endif
> +
> +#include "defs.h"
> +#include "gdb_assert.h"
> +#include <ctype.h>
> +#include "gdb_string.h"
> +#include "event-top.h"
>
> #ifdef __GO32__
> #include <pc.h>
>
> It needs to at least include "config.h" first (that is where HAVE_CURSES_H
> is defined). I think something like:
>
>
> #include "config.h"
> #include "bfd.h"
> #include "defs.h"
No, just include "config.h" and then <curses.h> before defs.h.
> but the ``I think'' highlights the problem :-( I don't think we should
> be working around problems in an un released BFD :-/
I don't follow that. If we ever, ever built using a "system" bfd.h,
maybe. BFD is part of our source distribution, for all that it is
owned by a different group. "Released" doesn't mean anything.
The names that would need to be changed are 'true' and 'false'. That's
a problem of fairly great magnitude.
(And I missed that Martin had forgotten config.h. That should have
caused some warnings...)
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer