This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Crossdebugging compilation fix for x86-64


Andreas Schwab wrote:
> What puzzles me more is the fact that x86_64_regmap is defined (and not
> just declared) in a header.  It is only used in x86-64-linux-nat.c, so it
> should be moved there (and that file can use <sys/reg.h> freely).

I already did this change in my tree and will post a patch for approval 
tomorrow.

And what about these declarations:
gdbarch_frame_saved_pc_ftype x86_64_linux_frame_saved_pc;
gdbarch_saved_pc_after_call_ftype x86_64_linux_saved_pc_after_call;
Shouldn't they go away from the header as well, so that only #defines 
will remain there as on other architectures?
Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]