This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH] stabsread.c: Fix for `ptype class Static' stabs FAIL
- From: "Peter.Schauer" <Peter dot Schauer at regent dot e-technik dot tu-muenchen dot de>
- To: ezannoni at redhat dot com (Elena Zannoni)
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 8 Mar 2002 18:27:00 MET
- Subject: [PATCH] stabsread.c: Fix for `ptype class Static' stabs FAIL
> Peter.Schauer writes:
> > The patch below fixes the `ptype class Static' stabs FAIL from classes.exp.
> >
> > Ok to commit ?
> >
>
> If it only affects c++ (and it looks like it does) and if DanielJ says
> Ok, it's fine with me.
>
> Elena
Thanks, committed, with more comment improvements.
2002-03-08 Peter Schauer <pes@regent.e-technik.tu-muenchen.de>
* stabsread.c (read_member_functions): Fix is_stub test for
static member functions, improve comment.
--- ./stabsread.c.orig Sat Feb 23 12:17:26 2002
+++ ./stabsread.c Fri Mar 8 18:08:00 2002
@@ -3287,13 +3287,30 @@ read_member_functions (struct field_info
}
case '?':
/* static member function. */
- new_sublist->fn_field.voffset = VOFFSET_STATIC;
- if (strncmp (new_sublist->fn_field.physname,
- main_fn_name, strlen (main_fn_name)))
- {
- new_sublist->fn_field.is_stub = 1;
- }
- break;
+ {
+ int slen = strlen (main_fn_name);
+
+ new_sublist->fn_field.voffset = VOFFSET_STATIC;
+
+ /* For static member functions, we can't tell if they
+ are stubbed, as they are put out as functions, and not as
+ methods.
+ GCC v2 emits the fully mangled name if
+ dbxout.c:flag_minimal_debug is not set, so we have to
+ detect a fully mangled physname here and set is_stub
+ accordingly. Fully mangled physnames in v2 start with
+ the member function name, followed by two underscores.
+ GCC v3 currently always emits stubbed member functions,
+ but with fully mangled physnames, which start with _Z. */
+ if (!(strncmp (new_sublist->fn_field.physname,
+ main_fn_name, slen) == 0
+ && new_sublist->fn_field.physname[slen] == '_'
+ && new_sublist->fn_field.physname[slen + 1] == '_'))
+ {
+ new_sublist->fn_field.is_stub = 1;
+ }
+ break;
+ }
default:
/* error */
--
Peter Schauer pes@regent.e-technik.tu-muenchen.de