This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] Delete write_fp() and friends


On Mar 28, 12:10pm, Michael Snyder wrote:

> > >> So what should calls to write_fp be replaced with?
> > >
> > > It looks to me like there was only one call to write_fp() and that
> > > occurred in sparc-tdep.c.  Andrew replaced that call with a call to
> > > write_register().
> > 
> > I need to examine that a bit more carefully though.
> 
> If no one but Sparc is using it, I'm not very worried
> (as long as you take care of sparc).

Well, for the sparc, it appears that it's only the sim which
cares about it.  From sparc_push_dummy_frame():

  if (strcmp (target_shortname, "sim") != 0)
    {
      write_fp (old_sp);

      /* Set return address register for the call dummy to the current PC.  */
      write_register (I7_REGNUM, read_pc () - 8);
    }
  else
    ...

I wonder why the sim was being special cased in the first place?

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]