This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: spu autoconfiscation patch


On Tue, Apr 02, 2002 at 02:56:14PM -0500, Nathanael Nerode wrote:
> Reposting...
> 
> 'configure' is not included in the patch below because I couldn't get
> cvs diff to handle a new file.  It's generated from configure.in anyway.
> 
> The whole files are probably easier to read than the diffs.

Please don't use straight diff; it's unreadable.  Use contextual or
unified diffs - I think the preference for most GNU projects is
contextual (I'm a unified person, myself....)

> I did not attempt to cure any bugs or portability issues in SPU, as I
> do not feel that I am a competent enough C programmer to do so; this is
> just enough that the 'utils' and top level autoconfiscations will be
> possible.
> 
> With this patch, spu configures, builds, and has no behavior changes on
> my Debian woody system (i686-pc-linux-gnu).  (The programs which SPU
> generates are identical before and after.)
> 
> Apr 2 2002 Nathanael Nerode

You also may want to look at GNU changelog formatting.  That should be:

2002-04-02  Nathanael Nerode  <neroden@doctormoo.dyndns.org>

(note the double spaces)

> 	* utils/spu/configure.in: autoconfiscated.
> 	* utils/spu/Makefile.in: autoconfiscated.
> 	* utils/spu/configure: new autoconf-generated file.

GDB folks: This patch is simple and seems obviously correct to me.
Since I'm allowed to check in changes to configury, I'm going to sit on
this for two or three days, and check it in to the trunk if there are
no objections.  Speak now or, etc.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]