This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Obvious fix in values.c?
- From: Jim Ingham <jingham at apple dot com>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 19 Apr 2002 16:23:55 -0700
- Subject: Re: Obvious fix in values.c?
Daniel,
I'll take a look at it after Apple's WWDC (mid-May). I won't have time
till then.
Jim
On Friday, April 19, 2002, at 03:58 PM, Daniel Jacobowitz wrote:
> On Fri, Apr 19, 2002 at 02:28:44PM -0700, Jim Ingham wrote:
>> Do folks agree that this falls under the obvious fix rule? It doesn't
>> seem safe to assume that all demangled names will contain a space (and
>> in fact, gdb crashed on someone when the assumption was proved
>> false...).
>>
>> 2002-04-19 Jim Ingham <jingham@apple.com>
>>
>> * values.c (value_headof): Don't assume all demangled names contain
>> a space.
>
> Could I please get you to solve this properly? Kill the one and only
> use of this function in printcmd.c via value_from_vtable_info. If you
> simply cast the pointer to a pointer to the proper base type, found via
> value_rtti_type, this function can die. It should just work (and/or be
> more useful than the current behavior).
>
> --
> Daniel Jacobowitz Carnegie Mellon University
> MontaVista Software Debian GNU/Linux Developer
>
--
Jim Ingham jingham@apple.com
Developer Tools - gdb
Apple Computer