This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]Use prev_lexptr in *-exp.y
- From: Michael Snyder <msnyder at redhat dot com>
- To: Pierre Muller <muller at cerbere dot u-strasbg dot fr>
- Cc: Andrew Cagney <ac131313 at cygnus dot com>, gdb-patches at sources dot redhat dot com
- Date: Fri, 03 May 2002 10:28:54 -0700
- Subject: Re: [RFA]Use prev_lexptr in *-exp.y
- Organization: Red Hat, Inc.
- References: <4.2.0.58.20020425103344.024be7a8@ics.u-strasbg.fr> <4.2.0.58.20020425183926.020b6350@ics.u-strasbg.fr> <4.2.0.58.20020502153022.03355760@ics.u-strasbg.fr> <4.2.0.58.20020503100132.01ae1b08@ics.u-strasbg.fr>
Pierre Muller wrote:
>
> At 19:49 02/05/2002 , Michael Snyder a écrit:
> >Pierre Muller wrote:
> > >
> > > At 20:38 25/04/2002 , Michael Snyder a écrit:
> > > >Pierre Muller wrote:
> > > > >
> > > > > At 17:30 25/04/2002 , Andrew Cagney a écrit:
> > > > > >>2002-04-25 Pierre Muller <muller@ics.u-strasbg.fr>
> > > > > >>* p-exp.y: Also use new prev_lexptr variable
> > > > > >> to improve error reporting. Based on Michael Snyder
> > > > > >> 2002-04-24 dated patch to c-exp.y.
> > > > > >
> > > > > >Nice. Can I suggest creating bug report so we know that the others should be done.
> > > > >
> > > > > This is more work than fixing them directly!
> > > >
> > > >ROTFL! You rock, Pierre! <g>
> > >
> > > May I consider this as an approval and commit this patch?
> >
> >Aha, the files have no maintainer! OK, yes, donning my omnipotence hat,
> >I approve your change. ;-)
>
> Thanks, committed.
>
> By the way, I don't have the necessary stuff to run the
> testsuite... Thus I can not warranty that there are no
> regressions. There mught be some wrong regressions,
> if some testsuite do check the error output in case of
> wrong expression entered. The error output should be more
> logical now, but could get some tests to fail.
Yes, I'm waiting for someone to complain. None of the C or C++
tests have failed because of this (and I presume you've tested
pascal).