This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH/RFC] Generic OS ABI handling for gdbarch
- From: Jason R Thorpe <thorpej at wasabisystems dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 13 May 2002 08:49:08 -0700
- Subject: Re: [PATCH/RFC] Generic OS ABI handling for gdbarch
- Organization: Wasabi Systems, Inc.
- References: <20020511212045.I3435@dr-evil.shagadelic.org> <3CDF4D07.2050805@cygnus.com>
- Reply-to: thorpej at wasabisystems dot com
On Mon, May 13, 2002 at 01:20:07AM -0400, Andrew Cagney wrote:
> > +/* List of known OS ABIs. If you change this, make sure to update the
> > + table in osabi.c. */
>
> Suggest checking this in _initialize_osabi().
Ok. Sufficient to check that the last one is NULL?
> What is the overhead of the ``sniff test''? Can I suggest checking all
> regardless and then internal_error()ing on a double hit.
>
> In the one hand, this means looking for trouble. On the other hand, it
> is the only way we'll flush out some bugs before the next release.
I don't think the overhead is that much. I mean, it only happens once
at the start of the debugging session, anyway, and I think sniffing the
BFD is going to be a lot faster than loading the symbol table of most
things, anyway :-)
So, I'll make this tweak, as well.
--
-- Jason R. Thorpe <thorpej@wasabisystems.com>