This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin

From: Andrew Cagney <ac131313 at ges dot redhat dot com>
To: Eli Zaretskii <eliz at is dot elta dot co dot il>
Cc: Michael Snyder <msnyder at redhat dot com>,gdb-patches at sources dot redhat dot com
Date: Tue, 06 Aug 2002 10:02:51 -0400
Subject: Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin
References: <Pine.SUN.3.91.1020806074046.5586A-100000@is>

On Mon, 5 Aug 2002, Michael Snyder wrote:
do we actually know of any environments
where the #if is strictly necessary?

Since GDB requires ISO C, and "wb" is part of the ISO C spec, I think we can drop the #if. (Dependance on O_BINARY being defined is not very clean anyway, IMHO, since O_BINARY does not belong to `fopen'.)

Just to be pedantic. GDB requires an ISO C syntax compiler but not the ISO C support libraries.

However, until there is evidence to the contrary, I agree we should assume it is going to work.

Andrew

References:
- Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]