This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] mips_init_extra_frame_info: Set saved_regs value for SP_REGNUM


This patch fixes the other code path mentioned in earlier mail
so that frame->saved_regs[SP_REGNUM] will be initialized at each
place where saved_regs is initialized.

For background on why this change is needed, see:

    http://sources.redhat.com/ml/gdb-patches/2002-08/msg00195.html

Okay to commit?

	* mips-tdep.c (mips_init_extra_frame_info): Initialize SP_REGNUM's
	saved regs value.
	
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.93
diff -u -p -r1.93 mips-tdep.c
--- mips-tdep.c	8 Aug 2002 23:32:52 -0000	1.93
+++ mips-tdep.c	9 Aug 2002 00:13:05 -0000
@@ -2342,6 +2342,7 @@ mips_init_extra_frame_info (int fromleaf
 	      memcpy (fci->saved_regs, temp_saved_regs, SIZEOF_FRAME_SAVED_REGS);
 	      fci->saved_regs[PC_REGNUM]
 		= fci->saved_regs[RA_REGNUM];
+	      fci->saved_regs[SP_REGNUM] = fci->frame;
 	    }
 	}
Yes, ok. Just add a comment reminding the reader that this is setting the SP for the previous frame.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]