This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa:i386] Eliminate register_byte() and register_raw_size()


Andrew Cagney <ac131313@ges.redhat.com> writes:


> This patch eliminates the register_byte() and register_raw_size()
> architecture methods from the i386.
>
> (It was either that or modify the code so that it included MMX
>  registers :-)

Well, the generic code is probably a wee bit slower...

...but we can always add back a more generic version of the "offset caching" code that your patch removes if that turns out to be a problem...
Or remove all calls to REGISTER_BYTE() :-) Oh, and the regcache already does ``offset caching'' :-)

> ok to commit?

...so it's fine with me.  Please go ahead.
Thanks!

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]