This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] Don't include vector registers in ``info registers''


Ah, compare with what the rs6000-tdep.c has:
rs6000_do_registers_info().

I made the same change, but also added a skipping of the print of a
single vector register in decimal, it was taking up too much screen
real estate.

          /* If not a vector register, print it also in decimal.  */
	  if (!altivec_register_p (i))
	    {
	      printf_filtered ("\t");
	      val_print (REGISTER_VIRTUAL_TYPE (i), virtual_buffer, 0, 0,
			 gdb_stdout, 0, 1, 0, Val_pretty_default);
	    }
Hmm, yes, the vector register output is a bit long.

I also did something different: defining altivec_register_p(). I was
envisioning this predicate becoming an architecture method called
vector_register_p().
Yes, I know GUI people are crying out for some sort of register attribute mechanism. If/when it is added the current tests could quickly be replaced with more generic code that, by default, used the current heuristics.

Another thing I've done in rs6000-tdep.c is the 'info vector' command
(even though it is called 'info altivec').

I'll be submitting shortly another powerpc variation (the e500) which
has vector registers, so I generalized things a bit in that file, wrt
vector registers.
Hmm...

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]