This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA/remote: Clean up remote_open_1 and friend
On Sun, Aug 11, 2002 at 11:26:07AM -0400, Andrew Cagney wrote:
> >I was looking at some future changes to remote_open_1, and didn't want to
> >duplicate them in remote_async_open_1, so I folded the two functions
> >together. The changes were pretty small, and I think reasonable. Andrew,
> >any thoughts? This will let me kill the wrapper functions in a later
> >patch,
> >I think. I'm considering adding local state to the target stack right
> >now... which will make autodetecting which remote protocol to use even
> >simpler and cleaner.
>
> Yes!
>
> >+ remote_open_1 (name, from_tty, &extended_remote_ops, 1 /*extended_p */,
> >0);
>
> Can you just add a parameter name comment so it reads ``0 /* async_p */''.
Committed with that tweak.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer